Fix expected error code in tests when ext-sockets is not enabled#532
Merged
WyriHaximus merged 1 commit intoreactphp:3.xfrom Aug 27, 2024
Merged
Fix expected error code in tests when ext-sockets is not enabled#532WyriHaximus merged 1 commit intoreactphp:3.xfrom
WyriHaximus merged 1 commit intoreactphp:3.xfrom
Conversation
Member
|
@lucasnetau Thanks for bringing this up 👍 Seems like a reasonable change to me, but I don't have at much insights on this as @clue and @WyriHaximus, so interested in their opinion on this. |
clue
approved these changes
Aug 10, 2024
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@lucasnetau Thank you for looking into this, changes LGTM! 
This fixes a small oversight in our test suite only that I've introduced when removing the dependency on reactphp/promise-stream (#482).
Once merged, we should probably backport the same changes to the 1.x branch as well 👍
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Aug 27, 2024
This is a backport of reactphp#532 and corrects an oversight introduced in reactphp#482.
Member
Just filed #539 to address this in the |
WyriHaximus
approved these changes
Aug 27, 2024
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
Thanks for taking the time to file this fix, LGTM 👍
WyriHaximus
pushed a commit
to WyriHaximus-labs/http
that referenced
this pull request
Aug 30, 2024
This is a backport of reactphp#532 and corrects an oversight introduced in reactphp#482.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected error code when ext-sockets is not enabled (SOCKET_EMSGSIZE is not defined) is 90 per the two places that OverFlowException is created in class Transaction
http/src/Io/Transaction.php
Lines 173 to 176 in 212382c
http/src/Io/Transaction.php
Lines 205 to 208 in 212382c